Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change startpage-ui to startPage-ui, to fix CI #14111

Merged
merged 3 commits into from
Sep 25, 2020
Merged

change startpage-ui to startPage-ui, to fix CI #14111

merged 3 commits into from
Sep 25, 2020

Conversation

DavidKutu
Copy link

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@DavidKutu DavidKutu added the no-changelog No news entry required label Sep 25, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020 •
edited
Loading

Codecov Report

Merging #14111 into WIP/NoDS will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           WIP/NoDS   #14111      +/-   ##
============================================
- Coverage     66.14%   66.09%   -0.06%     
============================================
  Files           528      528              
  Lines         24051    24033      -18     
  Branches       3378     3372       -6     
============================================
- Hits          15909    15884      -25     
- Misses         7523     7527       +4     
- Partials        619      622       +3
Impacted Files Coverage Δ
src/client/common/experiments/groups.ts 100.00% <ø> (ø)
src/client/common/experiments/manager.ts 95.86% <ø> (-0.14%) ⬇️
src/client/common/startPage/codeCssGenerator.ts 7.36% <ø> (ø)
src/client/common/types.ts 100.00% <ø> (ø)
src/client/common/startPage/startPage.ts 30.96% <100.00%> (ø)
...very/locators/services/virtualenvwrapperLocator.ts 76.92% <0.00%> (-15.39%) ⬇️
src/client/common/utils/platform.ts 60.00% <0.00%> (-8.00%) ⬇️
.../pythonEnvironments/common/externalDependencies.ts 66.66% <0.00%> (-4.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eb3d42...49e4b50. Read the comment docs.

David Kutugata added 2 commits September 25, 2020 15:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DavidKutu DavidKutu changed the title change startpage-ui to startPage-ui change startpage-ui to startPage-ui, to fix CI Sep 25, 2020
@DavidKutu DavidKutu merged commit 2ab1c9c into WIP/NoDS Sep 25, 2020
@DavidKutu DavidKutu deleted the david/fixCI2 branch September 25, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchiodo rchiodo rchiodo approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

@joyceerhl joyceerhl Awaiting requested review from joyceerhl

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidKutu @codecov-commenter @rchiodo